Fix SLAS client update and add open command#43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slas client opencommand to open the SLAS Admin UI in browserDetails
Bug #41 Fix
The SLAS API returns
redirectUrias a pipe-delimited string (e.g.,"url1|url2|url3") but the PUT endpoint expects an array of individual URLs. The update command was wrapping the entire pipe-delimited string as a single array element instead of splitting it.Before:
After:
New
slas client openCommandOpens the SLAS Admin UI in the browser, deep-linking to a specific client:
URL pattern:
https://{shortCode}.api.commercecloud.salesforce.com/shopper/auth-admin/v1/ui/client?clientId={clientId}&tenantId={tenantId}Test plan
b2c slas client update --scopes <scope> <clientId> --tenant-id <tenantId>on a client with existing redirect URIsb2c slas client open <clientId> --tenant-id <tenantId>and verify browser opens to correct URLpnpm run buildto verify compilationpnpm --filter @salesforce/b2c-cli run lintto verify linting passes